Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove change value #164

Closed
wants to merge 1 commit into from
Closed

Remove change value #164

wants to merge 1 commit into from

Conversation

grod220
Copy link
Contributor

@grod220 grod220 commented Nov 25, 2024

Closes #152

Before:
Screenshot 2024-11-25 at 1 08 11 PM

After:
Screenshot 2024-11-25 at 1 08 05 PM

@grod220 grod220 requested a review from a team November 25, 2024 12:13
Copy link
Contributor

@VanishMax VanishMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: what is the reason of removing the change value? It was really useful for me personally, it is almost the first thing I look for in similar websites

@grod220
Copy link
Contributor Author

grod220 commented Nov 25, 2024

Amongst the feedback in the review from @hdevalence. I'm not sure a base change number denominated in the asset denom is that understandable by users.

@hdevalence
Copy link
Member

Yeah, open to discussion on it but my opinion is/was that reporting an absolute number for the change is less informative than a percent and that it's visually cleaner to just show the relative number. But if others feel that it's useful we can leave it in

@hdevalence
Copy link
Member

I have weak conviction on this point

@TalDerei
Copy link

TalDerei commented Nov 25, 2024

I personally find it very useful to keep, as it's the first thing I look for as well. Dolemite only shows the percentage change, but I found myself spending more time trying to interpret the price information without it.

Screenshot 2024-11-25 at 6 58 19 AM

@grod220 grod220 closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove absolute amount from summary
4 participants